Design comparison
Solution retrospective
The QR code is CSS only (pixel art) using box-shadow property.
Community feedback
- @HassiaiPosted over 1 year ago
Replace <div class="▌│█║▌║▌║"> with the main tag to fix the accessibility issues. click here for more on web-accessibility and semantic html
To center .▌│█║▌║▌║ using grid replace the height in the body with min-height: 100vh.
Give h1 and p the same font-size of 15px which is 0.9375rem, text-align: center,the same margin-left, margin-right and margin-top values. Give p a margin bottom value.
For a responsive content,
- Give .▌│█║▌║▌║ a fixed max-width value and a padding value for all the sides
max-width: 320px which is 20rem/em padding:16px which is 1rem/em
- Give the img a max-width of 100% and a border-radius value, the rest are not needed.
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
0@j3rech0Posted over 1 year ago@Hassiai Thanks!, but there's no
img
tag in the code :P, I just have so much time with box-shadow :D0 - Give .▌│█║▌║▌║ a fixed max-width value and a padding value for all the sides
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord