Submitted almost 3 years ago
QR Code Component using html5, CSS and media queries
@NicolasGula
Design comparison
SolutionDesign
Solution retrospective
Any suggestions on how I can improve are welcome!
Community feedback
- @DrougnovPosted almost 3 years ago
Hello @NicolasGula, you did a marvelous job on the design. It's perfect.
However, you need to improve your Html code's accessiblity. Change/Add these things:
- Use
main
,footer
,section
,article
etc. instead ofdiv
. - Use responsive unit like
rem
,em
instead ofpx
- You need atleast one heading in your page. You can change the
<p class="title">
toh1 class="title"
Overall, the design looks great. Keep it up. Have a good day, my friend :)
Marked as helpful1@NicolasGulaPosted almost 3 years ago@Drougnov Thank you so much for the feedback. I appreciate. Take note of your advice.
1 - Use
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord