QR Code Component using HTML5 Boilerplate & Normalize.css

Community feedback

• 

  Kamlesh Rajesh Yadav•5,060

  @Kamlesh0007Posted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  I have other recommendations regarding your code that I believe will be of great interest to you. CSS 🎨:

  Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using margin or padding. We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📚. For this demonstration we use css Grid to center the component. body { min-height: 100vh; display: grid; place-items: center; }

  Marked as helpful

  0

  ---

  

  billccr•90

  @billccrPosted over 1 year ago

  @Kamlesh0007 Thanks very much for the feedback, Kamlesh. It's much appreciated.

  I did use Flexbox for the layout, but have not yet tried the use of vh in sizing the component. I'll take another run with this in mind and see how it goes.

  Thanks!

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  COMPONENT MEASUREMENTS 📐:

  • Use min-height: 100vh for .container instead of height: 900px. Setting the height: 900px may result in the component being cut off on smaller screens.

  ---

  • For example; if we set height: 900px then the body will have 900px height no matter what. Even if the content spans more than 100% of viewport.

  ---

  • But if we set min-height: 100vh then the body will start at 100vh, if the content pushes the body beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  billccr•90

  @billccrPosted over 1 year ago

  @0xAbdulKhalid Thank you very much, Abdul. I'm happy to get such a specific recommendation. I'll definitely look into this further. vh is not something I'm familiar with up to now.

  Thanks again!

  0