QR code component using HTML5 & CSS3

Community feedback

• 

  Baki Jessy Justice Julien•110

  @blackdreamer15Posted over 2 years ago

  Hi @kermitcosts! Congratulations on completing this challenge. I checked your code on GitHub and have some suggestions to make.

  1. You have to use a <h1> tag instead of a <p class="first-text"></p> to resolve one of the accessibility issues.

  2. For the semantic reasons, it will be best to change <div class="main"></div> to <main class="main" role="main"></main> since it contains the main content of the page. Let it embed the whole main content of the page.

  Good luck with your other challenges.

  Marked as helpful

  0

  ---

  

  Kermit Costa•20

  @kermitcostaPosted over 2 years ago

  Hi! @blackdreamer15. Thank you for your feedback! I already make the changes and they aren't pointing any issues right now.

  0

  

  Baki Jessy Justice Julien•110

  @blackdreamer15Posted over 2 years ago

  Great work, @kermitcosta. Up to for the next one.

  0