QR code component using html

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Stephanie, good job! I took some time to look at your code and have some ideas for improving it:

  • remove all unnecessary code, the less you write the better as well as being clearer: for example the div child of section
  • to make it look as close to the design as possible add width: 21rem to card class
  • remove all margin from card class
  • try to use flexbox to the body for center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container and remove margin-top from body

  Overall you did well 😉

  Hope this help and happy coding!

  Marked as helpful

  0

  ---

  

  Stephanie Ezinne•140

  @stephanniegbPosted over 2 years ago

  @denielden thanks I appreciate

  1