Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component using html

@stephanniegb

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


feedback needed

Community feedback

Travolgi 🍕 31,420

@denielden

Posted

Hi Stephanie, good job! I took some time to look at your code and have some ideas for improving it:

  • remove all unnecessary code, the less you write the better as well as being clearer: for example the div child of section
  • to make it look as close to the design as possible add width: 21rem to card class
  • remove all margin from card class
  • try to use flexbox to the body for center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container and remove margin-top from body

Overall you did well 😉

Hope this help and happy coding!

Marked as helpful

0

@stephanniegb

Posted

@denielden thanks I appreciate

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord