QR code component using HTML, Sass and Bootstrap

Community feedback

• 

  Piyath•160

  @piyathpereraPosted over 2 years ago

  Hi Richardo,

  Congratulations on completing the design..

  You can give background-color to a parent element that has the full width of the page. Easy fix there.

  Just make sure to check issues mentioned in report after submission. Basically saying Using Section Heading elements at least once. (H1-H6 in any title of a page/component). Also using correct semantic landmark regions to separate your html structure. header, main, footer etc.

  Try to avoid using fixed values for heights and widths. Research on units that you can use in css, There is a lot of them. "ch" is better for the card's content. Try them, see what works. This also helps to reduce number of breakpoints needed.

  Make your design responsive as much as you can without any breakpoints. Breakpoints are as the named suggests used when design breaks. For most challenges you can use combination of flex and grid. To better understand this, search of "Intrinsic web design" "Designing Intrinsic Layouts by Jen simmons".

  This is one of best go to sites to learn the web right away, information fairly accurate and upto date. https://developer.mozilla.org/en-US/docs/Learn

  Keep building stuff.

  Marked as helpful

  0

  ---

  

  Ricardo Fuentes Urbina•370

  @RicardoFuentes437Posted over 2 years ago

  @piyathperera Hello, thank you very much for all of your recommendations, i'll definitely try to implement them of future challenges, and i'll check out that site.

  Kind regards :)

  0
• Account deleted

  Hey Ricardo,

  If you want your main background color to cover the entire screen, set the background color to the body in css.

  Also, according to your report, there is some issues with a lack of heading. If you set the text underneath the QR code to h1, that should clear up any problems there.

  Hope that helps you.

  Marked as helpful

  0

  ---

  

  Ricardo Fuentes Urbina•370

  @RicardoFuentes437Posted over 2 years ago

  @simmonscode hello, thank you so much for your comment :) the background color covering only that section was kind of a personal choice, but i'll keep in mind your recommendation.

  Also thank you because i didn't really get what that lack of heading issue meant.

  Kind regards :)

  0

  Account deleted

  @RicardoFuentes437 I understand. Glad I could help

  0