Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component using html

Stephanie Ezinneβ€’ 140

@stephanniegb

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


feedback needed

Community feedback

Abreham Nigussieβ€’ 470

@DreamCoder7

Posted

Well done, great job.

But there is problem with your styling. First instead of using inline style you can use external file and link to your HTML that way it's better to view your code. Second I kind of looking your styling code and I found that some of your code not necessary or duplicated and also messing some style.

Here are some changes I made in browser that should help with remove unnecessary code:

/*You should name your HTML tag as necessary for the feature*/
div{
  text-align: center;
}

/*This is the parent element*/
main {
    display: flex;
    justify-content: center;
}

.card {
    background-color: white;
    /* Not necessary you can center your card by styling the parent element */
    /* display: flex;*/
    /*justify-content: center; */
    /* flex-direction: column; */
    /* margin-left: 500px; */
    /* margin-right: 500px; */
    /* padding-top: 15px;*/
    /*padding-left: 5px;*/
    /*padding-right: 5px; */
    padding: 15px 5px 0 5px; // You can do it in one line
    border-radius: 10px;
    box-shadow: 0 4px 8px 0 rgba(0, 0, 0, 0.2);
    transition: 0.3s;
}  
```;

Marked as helpful

0

Stephanie Ezinneβ€’ 140

@stephanniegb

Posted

@redstorm-hub thanks I understand

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord