QR code component using html

Community feedback

• 

  Abreham Nigussie•470

  @DreamCoder7Posted over 2 years ago

  Well done, great job.

  But there is problem with your styling. First instead of using inline style you can use external file and link to your HTML that way it's better to view your code. Second I kind of looking your styling code and I found that some of your code not necessary or duplicated and also messing some style.

  Here are some changes I made in browser that should help with remove unnecessary code:

  /*You should name your HTML tag as necessary for the feature*/
  div{
    text-align: center;
  }
  
  /*This is the parent element*/
  main {
      display: flex;
      justify-content: center;
  }
  
  .card {
      background-color: white;
      /* Not necessary you can center your card by styling the parent element */
      /* display: flex;*/
      /*justify-content: center; */
      /* flex-direction: column; */
      /* margin-left: 500px; */
      /* margin-right: 500px; */
      /* padding-top: 15px;*/
      /*padding-left: 5px;*/
      /*padding-right: 5px; */
      padding: 15px 5px 0 5px; // You can do it in one line
      border-radius: 10px;
      box-shadow: 0 4px 8px 0 rgba(0, 0, 0, 0.2);
      transition: 0.3s;
  }  
  ```;
  

  Marked as helpful

  0

  ---

  

  Stephanie Ezinne•140

  @stephanniegbPosted over 2 years ago

  @redstorm-hub thanks I understand

  0