QR Code component using HTML, CSS and flexbox

Community feedback

• 

  Kamlesh Rajesh Yadav•5,060

  @Kamlesh0007Posted over 1 year ago

  Congratulations on completing the challenge! That's a great achievement, and I'm sure you put a lot of effort into it. I really liked the way you approached the challenge and the code you wrote. You demonstrated a good understanding of the concepts and applied them effectively to solve the problem.I have a few suggestions to improve your code further. make the container center properly use min-height:100vh which is used to ensure that a container or element takes up at least the full height of the viewport (the visible area of the browser window) regardless of the content inside it.

  Here's an example code snippet:

  body {
  display: flex;
  justify-content: center;
  min-height:100vh 
  align-items: center;
  flex-direction: column; 
  }
  
  now remove below lines of code
  .attribution {
  margin-top: auto;
  }
  now ur container will be center
  

  Marked as helpful

  0

  ---

  

  Dale Torres•50

  @daletorresPosted over 1 year ago

  @Kamlesh0007 appreciate the feedback! I'll make the changes to my solution and keep that in mind for future challenges and projects.

  0