@kepper104
Posted
Great job! A few points of feedback:
- Don't use line breaks (
br
), try just letting the text wrap itself, add horizontal padding if needed. - The card from the reference design has a shadow, and I think yours doesn't.
- Also you left out a default (?)
Document
page title in the header section of the HTML, maybe change it to something likeQR Code Card
. - Finally, the card is vertically off-center a bit, but that's a minor thing, I would add something like
html, body {
display: flex;
height: 100%;
width: 100%;
align-items: center;
justify-content: center;
}
to the CSS, that way the card will be centered (you will also have to remove the margin
and margin-top
from the div
styling)
First time writing a code review, so sorry if the wording is a bit off or anything else ;)
Marked as helpful
@A-Young-Git
Posted
@kepper104 thank you so much! Thorough review and i can see everything you pointed out. I owe you one!