Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Code Component Using HTML And Flexbox

@A-Young-Git

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

I am proud that I was able to match the design well and pick up some beginner experience and knowledge.

What challenges did you encounter, and how did you overcome them?

CSS knowledge gap

What specific areas of your project would you like help with?

CSS expertise

Community feedback

kepper104 90

@kepper104

Posted

Great job! A few points of feedback:

  • Don't use line breaks (br), try just letting the text wrap itself, add horizontal padding if needed.
  • The card from the reference design has a shadow, and I think yours doesn't.
  • Also you left out a default (?) Document page title in the header section of the HTML, maybe change it to something like QR Code Card.
  • Finally, the card is vertically off-center a bit, but that's a minor thing, I would add something like
html, body {
    display: flex;
    height: 100%;
    width: 100%;
    align-items: center;
    justify-content: center;
}

to the CSS, that way the card will be centered (you will also have to remove the margin and margin-top from the div styling)

First time writing a code review, so sorry if the wording is a bit off or anything else ;)

Marked as helpful

1

@A-Young-Git

Posted

@kepper104 thank you so much! Thorough review and i can see everything you pointed out. I owe you one!

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord