Qr Code Component using Html and Css/Sass

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 3 years ago

  Hi Hugo, congrats on completing the challenge!

  I had a look at your final solution and I have a few suggestions for you that I hope will be useful:

  • adding the follow property to the main tag for center the card

  justify-content: center;
  align-items: center;
  

  • remove all margin from .card class become superfluous

  Very nice the enlargement effect with hover :)

  You did well, keep it up ;) and happy coding!

  Marked as helpful

  1

  ---

  

  Hugo Padilla•210

  @HugoPadillaPosted almost 3 years ago

  @denielden Thanks for your comment. You are right, trying to center the card using margin: auto can be confusing at first glance. I will follow your recommendations. Thank you very much.

  1
• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted almost 3 years ago

  Hi Hugo

  Well done, that looks pretty close to the design for me. In the main I see you have this css declaration widows: 100%. I haven't used it before, but I read that it has to do with number of lines, I am interested to know more about it especially what changes or differences is it bringing to your site.

  1

  ---

  

  Hugo Padilla•210

  @HugoPadillaPosted almost 3 years ago

  @ChamuMutezva Thanks for your comment! It doesn't really make any significant change. It is a mistake on my part, maybe I wanted to use the width: 100% property, which in fact is not necessary because I want the width driven by the child elements, but for some reason I have snuck this property.

  Thanks for your question, I have corrected my code.

  1