Design comparison
Solution retrospective
All feedback is welcome
Community feedback
- @HassiaiPosted over 1 year ago
Wrap <div class="attribution"> with the footer tag and replace <p class="contenedor__texto--agrandar"> with <h1> to fix the accessibility issues.
Every html must have <h1> to make it accessible. Always begin the heading of the html with <h1> tag wrap the sub-heading of <h1> in <h2> tag, wrap the sub-heading of <h2> in <h3> this continues until <h6>, never skip a level of a heading.
To center .contenedor on the page using flexbox, add min-height:100vh; display: flex; align-items: center: justify-content: center; to the body
body{ min-height: 100vh; display: flex; align-items: center; justify-content: center; }
Use the colors that were given in the styleguide.md found in the zip folder you downloaded.
For a responsive content,
- Give .contenedor a fixed max-width value and a padding value for all the sides
max-width: 320px which is 20rem/em padding:16px which is 1rem/em
- Give the img a max-width of 100%.
Give .contenedor_texto a margin value for all the sides, text-align: center and a font-size of 15px which is 0.9375rem, this will be the font-size of both p and h1. Give p a margin-top or h1 a margin-bottom value for the space between the text.
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful1 - Give .contenedor a fixed max-width value and a padding value for all the sides
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord