QR code component using html and css

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing the <div class="container"> element with the proper semantic element <main> in your index.html file to improve accessibility and organization of your page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0
• 

  Shivraj K•400

  @Shivraj-K09Posted over 1 year ago

  Overall, the code structure is good and easy to understand. You have used appropriate HTML tags and included a meta viewport tag for responsiveness. Your CSS selectors are also properly named.

  However, there are some areas of improvement that I would like to mention:

  • In the style.css file, the font size unit for .how selector is missing (it currently reads as font-size: px;), which may cause issues in your webpage's display. You should edit this line to include a valid font-size unit such as px, em, or %.
  • The max-width property for .container selector has a fixed value of 360px, which might be too small for certain devices. Instead, you can use a max-width value in em or % units to make your webpage more responsive.
  • The justify-content property is not applicable to the .attribution selector as it is currently a div element. You may want to either give it a display of flex or use text-align: center instead.
  • In the attribution section, the challenge link to "Frontend Mentor" should have the rel="noopener noreferrer" attribute added to the <a> tag. This attribute is used as a security measure to protect against vulnerability exploits related to link hijacking, by preventing the new page from being opened in the same window, potentially allowing the destination site to take control of the source site.

  Other than these minor issues, your code looks good and functions as intended. Good job and Happy Coding 🫡😉

  0