QR Code component using HTML and CSS

Community feedback

• 

  Scott Burgess•110

  @ScottburgPosted almost 2 years ago

  Replace <div class="attribution"> with the footer tag and the <div id="wrapper"> with a <section> tag to fix the accessibility issue. click here for more on web-accessibility and semantic html.

  Only other minor point is that the original card has a light box-shadow property which helps the card to pop out the page a bit more.

  Great job, keep it up!

  Marked as helpful

  1
• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hello there 👋. Good job on completing the challenge !

  I have other suggestions about your code that might interest you.

  HTML 📄:

  • The alt attribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a better alt attribute would be QR code to frontendmentor.io

    If you want to learn more about the alt attribute, you can read this article. 📘.

  CSS 🎨:

  • The width: 100% property in the body tag is not necessary. The body tag is a block element and it will take the full width of the page by default.

  • Use min-height: 100vh instead of height: 100vh. The height property will not work if the content of the page grows beyond the height of the viewport.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  1