QR Code Component Using HTML & CSS

Community feedback

• 

  Jimmy D.•160

  @Jd536Posted over 2 years ago

  Hey Kirsten,

  Great start! ✨

  The Background-colors match the design

  Here are a few things you could improve:

  1. Make sure the font-family match the Design. The style-guide file suggested Outfit Get Started with the Google Fonts API

  2. Set the font size to 15px (no big deal, but it's always best to follow design recommendation).

  3. Instead of using div around main class, you could use main for accessibility purposes.

  4. The last thing and the most important is that your solution is not responsive. The QR-code is not visible on mobile. Kindly update your code to match the mobile design. 🙂 Resource.Responsive design

  I hope this is helpful. Feel welcome to let me know if you have any questions.

  Have an excellent weekend. ☕

  Marked as helpful

  1

  ---

  

  Kirsten ✨•460

  @ofthewildfirePosted over 2 years ago

  @Jd536 Hi, thank you so much for your feedback, I was not aware I had to make both though, so thanks for that, I had picked this one because I don't know how to work with responsive and the little tag said it was good for a "first" without knowledge of responsive :) it's a little far in my lessons so it will be a while before I can update the code.

  I will update the font and sizing ASAP though, again, thank you so much! Appreciate it.

  0
• 

  Abdul•8,540

  @SamadeenPosted over 2 years ago

  Hey!! Cheers 🥂 on completing this challenge.. .

  Here are my suggestions..

  • You should use <main id="center"> instead of <div id="center">.
  • You can wrap your attribution section in a footer tag to avoid accessibility issues.

  This should fix most of your accessibility issues

  . Regardless you did amazing... hope you find this useful... Happy coding!!!

  Marked as helpful

  0