Skip to content
Submitted 10 months ago

QR code component using HTML and CSS

kerekiwere•420
@kerekiwere
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

My first challenge of many, really looking forward to hearing your feedback to help me grow! 🙂

Community feedback

  • Øystein Håberg•10,790
    @Islandstone89Posted 10 months ago

    Hi, well done! Here is some feedback:

    HTML:

    • The alt text must also say where it leads(frontendmentor.io).

    CSS:

    • Performance-wise, it's better to link fonts in the <head> of the HTML than using @import.

    • It's good practice to include a CSS Reset at the top.

    • Add around 1rem of padding on the body, so the card doesn't touch the edges on small screens.

    • Remove the height from html and body.

    • Add min-height: 100svh on body.

    • Change width to max-width on the image.

    • max-width on the card should be in rem.

    Marked as helpful
    1
    kerekiwere•420
    @kerekiwerePosted 10 months ago

    Very valuable feedback, I appreciate it! 👍

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord