Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component using HTML and CSS

kerekiwere• 380

@kerekiwere

Preview site(opens in new window)View code(opens in new window)
Desktop design screenshot for the QR code component coding challenge

This is a solution for...

QR code component
  • HTML
  • CSS
1newbie
View challenge

Design comparison

SolutionDesign

Solution retrospective

My first challenge of many, really looking forward to hearing your feedback to help me grow! 🙂

Community feedback

P
Øystein Håberg• 9,790

@Islandstone89

Posted

Hi, well done! Here is some feedback:

HTML:

  • The alt text must also say where it leads(frontendmentor.io).

CSS:

  • Performance-wise, it's better to link fonts in the <head> of the HTML than using @import.

  • It's good practice to include a CSS Reset at the top.

  • Add around 1rem of padding on the body, so the card doesn't touch the edges on small screens.

  • Remove the height from html and body.

  • Add min-height: 100svh on body.

  • Change width to max-width on the image.

  • max-width on the card should be in rem.

Marked as helpful

1
kerekiwere• 380

@kerekiwere

Posted

Very valuable feedback, I appreciate it! 👍

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord