QR code component using html and css

Community feedback

• 

  safdar•130

  @sfdrkPosted over 1 year ago

  Hi 👋 I think you could add margin for the main container .... so it will have the space on responsive . Just see in mobile screen it is enlarging to the edge of the screen.

  Marked as helpful

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which causes lacking of landmark for a webpage

  ---

  • So fix it by wrapping the <div class="card"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  Mary Nabwire•40

  @Mary83-opsPosted over 1 year ago

  @0xAbdulKhalid Noted

  0
• 

  Rohit Kumar•560

  @rohitKumar38344Posted over 1 year ago

  You have used the wrong syntax on box-shadow property on element having class (.card) It should be like this box-shadow: 0px 3px 25px; . You don't have to seperate the values using commas. Refer to mdn: https://developer.mozilla.org/en-US/docs/Web/CSS/box-shadow to read more about box-shadow. Happy Coding :D

  Marked as helpful

  0

  ---

  

  Mary Nabwire•40

  @Mary83-opsPosted over 1 year ago

  @rohitKumar38344 Okay I appreciate.

  0
• 

  Boluwatife Bonaventure•550

  @BoyutifePosted over 1 year ago

  Hi Mary Nabwire👋. Job well done Congratulations on successfully completing the challenge! 🎉

  I have some additional suggestions for your code that I believe will be of great interest to you.

  HTML 🏷️:

  -This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which lack landmark for a webpage. To address this issue, you can review the HTML code of the webpage and add appropriate landmarks where necessary. Some common landmarks that you may want to consider including are: <header> <main> <section> <aside> instead of multiple <div> <span> I hope you find this helpful 😄 Above all, the solution you submitted is great !

  -In your html file you could replace the <div class = 'card'> with <main>

  CSS:

  • You might considering changing the px to rem. rem and em are relative units in CSS, which means that their size is determined by their relationship to other elements in the document. In contrast, px is an absolute unit, which means that its size is fixed and does not change based on any other factors.

  -Overall, while there may be some cases where px is appropriate (e.g., for border widths or image sizes), using relative units like rem or em can help improve the accessibility and responsiveness of your website, as well as make it easier to maintain.

  Happy coding!

  Marked as helpful

  0

  ---

  

  Mary Nabwire•40

  @Mary83-opsPosted over 1 year ago

  @Boyutife Thank you. I'll make the changes

  0