QR Code Component using html and css

Community feedback

• 

  AriyanSep0_0•330

  @ARiYaNSEp0-0Posted 4 months ago

  Hello @faekhatami 🙋‍♂️. you did a good job on this challenge your result is pretty close to main design and here are some changes and improvements you can apply for getting closer to design and also some best practices maybe :

  • on this design there is no changes on mobile and desktop so for example there is no need to change font size on different breakpoints (font-size on heading is static 22px)
  • use accurate length values for spacing (padding, margin) typography and ... from figma file

  good luck.

  1

  ---

  

  faekhatami•540

  @faekhatamiPosted 4 months ago

  yeah you are right i think that was redundant. thank you for your comment i will consider them in my next practices! 🙋🏻‍♀️🌸 @ARiYaNSEp0-0

  1
• 

  KarolinaR98•190

  @KarolinaR98Posted 4 months ago

  This comment was deleted 4 months ago

  0

  ---

  

  AriyanSep0_0•330

  @ARiYaNSEp0-0Posted 4 months ago

  @KarolinaR98 Hi. we have a lot of centering methods in css and using flex and 100vh on body is one of them which mostly for single cards or components like this and there is no issue on that. but I am sure text-align : center not gonna work for putting card component on center of the page. and I think everything is simple on this challenge both design and implementation so ....

  1