QR Code Component using HTML and CSS

Hi Gabriel, good job.

Here are some suggestions :)

HTML:

• <main> holds all of the main content on a page. As a card would likely not be the only component on a page, I would wrap the card content in a <div class="card"> inside of <main>

• The alt text must also say where it leads(the frontendmentor website). Write something short and descriptive, without including words like "image" or "photo". Screen readers start announcing images with "image", so an alt text of "image of qr code" would be read like this: "image, image of qr code". A good alt text would be "QR code leading to the Frontend Mentor website."

• I would change the heading to a <h2> - a page should only have one <h1>, reserved for the main heading. As this is a card heading, it would likely not be the main heading on a page with several components.

• It's recommended to use classes instead of IDs. This article explains when to use the id attribute.

CSS:

• Including a CSS Reset at the top is good practice.

• Move font-family to body, it's not common to set any styles on html.

• I recommend adding 1rem of padding on the body, to ensure the card doesn't touch the edges on small screens.

• Using #container as a selector increases specificity, so I would use body as the selector instead. On the body, change height to min-height: 100svh - this way, the content will not get cut off if it grows beneath the viewport.

• On the card, remove height: auto, it is not needed. Change the max-width to 20rem, which equals 320px.

• font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

• letter-spacing must also not be in px. You can use em, where 1em equals the element's font size.

• On the image, add display: block and change width to max-width: 100% - the max-width prevents it from overflowing its container. Without this, an image would overflow if its intrinsic size is wider than the container. max-width: 100% makes the image shrink to fit inside its container. Remove height: 100%, it is not needed. You can set height: auto, though.

• Remove max-width on the image and the text.

It looks really nice and very identical. kudos. Though it looks like in your css you styled your elements in a disorganized manner. I recently learnt that it is good practice to style from top to bottom. I hope this feedback finds you well.