@vanzasetia
Posted
Hi, Muyiwa! 👋
Congratulations on completing your first Frontend Mentor challenge! 🎉
I recommend using a code-formatter. This way, your code base will have a consistent format which makes it easier to read the code. I suggest using Prettier as your code-formatter.
Prettier · Opinionated Code Formatter
The alternative text of the QR code doesn't need to be uppercased. Also, it should describe the QR code. In this case, it will navigate the users after they scan it. So, the better alternative text can be "QR code to frontendmentor.io".
Don't use id
selectors for styling. There are two reasons for not using ID’s to style content:
- They mess up specificity because they are too high (the most important reason).
- They are unique identifiers. So, they are not reusable on the same page.
Use single-class selectors whenever possible. This can help you produce a low-specificity stylesheet. As a result, it prevents you from having specificity issues.
Last suggestion, I recommend making the body
element as a flex container to place the card in the middle of the page. Then, set min-height: 100vh
to make the card vertically centered. After that, remove the relative positioning and margin: auto
from the #qrcomponent
,
I hope this helps. Happy coding!
Marked as helpful
@MuyiwaSaka
Posted
@vanzasetia This comment is really helpful.
I'll repeat this. Thanks for the help.
@vanzasetia
Posted
@MuyiwaSaka There is no need to repeat the challenge. Make some changes then do git commit
and after that git push
. This is what version control (Git) is used for.