QR Code component using HTML & CSS only

Community feedback

• 

  P

  Ericsson Mura 👦🏻•210

  @ericssonmuraPosted 4 months ago

  Hello there 👋. Good job on solving this challenge!

  The solution you submitted is great!

  I have some suggestions that you might find interesting:

  • Why not adding a box-shadow on the .qr-container div? For example:

  qr-container {
    box-shadow: 0 4px 22px rgba(0, 0, 0, 0.1);
  }
  

  • When using the margin shortcut, you can omit the last value and instead use 3 values:

  .qr-img {
      width: 288px;
      height: 288px;
      margin: 16px auto 0;
  }
  

  16px [for top] auto [left & right] 0 [bottom]

  Have a great day and keep coding ! 😄

  Marked as helpful

  1

  ---

  

  Tushar Jetagi•240

  @TusharJetagiPosted 4 months ago

  @ericssonmura Yes, I forgot to add shadow and thanks for correcting me.

  1

  

  P

  Ericsson Mura 👦🏻•210

  @ericssonmuraPosted 4 months ago

  @TusharJetagi

  Great code. Have a nice day!

  1
• 

  P

  Shalva Mghebrishvili•30

  @Shako-ITPosted 4 months ago

  I think some other HTML elements could be used here too, I mean "section", "h1", or "h2", instead of "div" and "p". I liked the HTML structure, the result is nice da looks appropriate to the challenge.

  1

  ---

  

  Tushar Jetagi•240

  @TusharJetagiPosted 4 months ago

  @Shako-IT Thank you so much for valuable feedback and I will keep in mind the suggestions you suggested.

  0
• 

  Vinayagam K•180

  @vinayagamRVKPosted 4 months ago

  Your code to this Challenge looks simplified and also it contains some of the good practices also ......overall it is Good developer Friendly solution @TusharJetagi

  1

  ---

  

  Tushar Jetagi•240

  @TusharJetagiPosted 4 months ago

  @vinayagamRVK Thank you so much for your valuable feedback.

  0