Skip to content
Submitted 11 months ago

QR Code Component using HTML and CSS

Sthefany Caires•40
@sthefanycaires
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Øystein Håberg•10,390
    @Islandstone89Posted 11 months ago

    Hi, here is some feedback - hope it helps :)

    HTML:

    • You don't need a <header> in this challenge, only a <main> and a <footer>. Move the image into the <main>. You don't need any divs, you can use the <main> as the card.

    • The alt text also needs to say where it leads (frontendmentor.io).

    CSS:

    • Performance-wise, it's better to link fonts in the <head> of the HTML than using @import.

    • It's good practice to include a CSS Reset at the top.

    • font-size must never be in px. This is bad for accessibility, as it prevents the font size from scaling with the user's default setting in the browser, Use rem instead.

    • On the body, change height to min-height.

    • Remove the fixed widths and heights. You rarely want to set fixed dimensions, as this easily creates issues with responsiveness.

    • Add a max-width of around 20rem on the card, to prevent it from getting too wide on larger screens.

    • Since all of the text is centered, you can set text-align: center on the body, and remove it elsewhere. The children of the body inherit the value.

    • It's common to add display: block and max-width: 100% to images - the max-width prevents it from overflowing its container.

    Marked as helpful
    1
    Sthefany Caires•40
    @sthefanycairesPosted 11 months ago

    Hello @Islandstone89! Thank you so much for your feedback! I made some changes to the code following the tips you mentioned, but I removed some elements from CSS Reset that I wasn't using and created an <article> tag with the <h1> and <p> tags, because the distance between the image and the <h1> was different from the distance between <h1> and <p>. Your tips really helped me improve my code, thank you!

    1
  • Øystein Håberg•10,390
    @Islandstone89Posted 11 months ago

    @sthefanycaires happy to help :) well done for taking on the feedback and implementing the changes.

    A few things to take note of:

    • You shouldn't wrap the text in an <article> . Regarding the spacing, you can check the DevTools to see if there's any default padding or margin that needs to be removed.

    • The default font size is 16px, so you don't have to explicitly declare it.

    • Remove the margin on the body.

    • Remove the percentage width on the card, and the height, as auto is the default.

    • As the design doesn't change, there is no need for any media queries. When you do need them, they should be in rem instead of px. Also, we normally want to do mobile styling first, and use media queries for larger screens, using min-width.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord