Design comparison
SolutionDesign
Solution retrospective
Any suggestions on how I can improve are welcome
Community feedback
- @vanzasetiaPosted over 2 years ago
Greetings, Michael Obi! 👋
Good effort on this challenge! 👍
Some recommendations from me.
- The styling of the card is consistent on both mobile and desktop. So, I would recommend making the site responsive without any media queries.
- The QR code is the main content of the site. So, it should be visible to all users. By leaving the
alt=""
empty, the users of the screenreader might not know that there's a QR code. So, I recommend giving some alternative text to it. - I recommend adding
rel="noopener"
to any anchor tags that havetarget="_blank"
. This is a security essential for external links. I suggest reading the web.dev article to learn more about this.
That's it! I hope this helps. 😊
Marked as helpful2
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord