Design comparison
Community feedback
- @gabrielmorandiPosted almost 2 years ago
Hi @tawiah007π, welcome to the Frontend Mentor Community!
I have some suggestions you might consider to improve your code:
-
First your code has repeated lines (right at the top of the page).
-
Try to put a
width
in px of your.code
, so that the screen size does not interfere with the size of your qr-code-component, making it more accessible, making it centered on the screen and with the same size. -
Use the
<main>
tag to define the main content within the<body>
in your document or application instead of using<div class="code">
to improve site accessibility. -
Use
<footer>
instead of<div class="attribution">
. The<footer>
element contains authorship information.
Finally I saw that in your code you used
@media screen
to make your site responsive, but you didn't style it, let's fix that?! Good job, and happy coding! πMarked as helpful0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord