Design comparison
SolutionDesign
Solution retrospective
what is the better way to create this project?
Community feedback
- @Aliyu-SaiduPosted almost 2 years ago
Nice job there, Jaqen. Keep it up. Here are some tips to help improve your code.
- Every website must have at least one landmark such as <main>, <header>, <footer> and so on, for improve accessibility. So you may consider wrapping your entire component by <main> by changing your <div class="main" > to just <main>.
- Every website should also have a level one heading (h1). You may want to replace the first paragraph <p class="first" > to <h1>.
- Since you are already wrapping entire website by <div class="main" > container and another <div class="container" >, you should consider removing all the specifications on 'body' element and place it inside the <div class="main" > and re-evaluate your code. I believe this should help place the design properly in the center (both vertically and horizontally). I hope this help? Happy coding
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord