QR Code Component using HTML and CSS

Community feedback

• 

  Jordan Phillips•425

  @JordanPhillips-hubPosted almost 3 years ago

  Looks good.. one other thing you could do on this is to switch the h2 to a h1 and change the font size to font-size: 1.375rem; this will get rid of the rest of your accessibility issues. Generally, it is a best practice to ensure that the beginning of a page's main content starts with a h1 element, and also to ensure that the page contains only one h1 element.

  Marked as helpful

  1

  ---

  

  Nicolás Herrera•70

  @herreranicolasPosted almost 3 years ago

  @JordanPhillips-hub thanks a lot for your feedback Jordan! 🙏 My mistake I forgot to correct what you mention! I'll keep on practicing and paying special attention to this!

  0
• 

  Naveen Gumaste•10,480

  @NaveenGumastePosted almost 3 years ago

  Hay ! Good Job you made it look nearly perfect to the preview

  These below mentioned tricks will help you remove any Accessibility Issues

  -> Add Main tag after body like it should be your container

  -> For 1st heading or h1 tag, use header tag and then inside the header put your h1 or h2 etc

  -> But use header tag only once in main heading element.

  Keep up the good work!

  Marked as helpful

  0

  ---

  

  Nicolás Herrera•70

  @herreranicolasPosted almost 3 years ago

  @Crazimonk thanks a lot for your feedback! 🙏 I find it hard sometimes since my knowledge is very basic but I really find this fascinating! How long would you say it's a fair time to solve this exercise? I think it took me too long and I also want to improve that. Thanks again!

  0

  

  Naveen Gumaste•10,480

  @NaveenGumastePosted almost 3 years ago

  @herreranicolas Take your own time to solve any challenge, as your knowledge grows you will solve them fast so no hurry!

  Keep up the good work!

  0
• 

  Kacper Kwinta•1,405

  @kacperkwintaPosted almost 3 years ago

  Looks really good, almost pixel perfect (:

  Some tips:

  • Page should contain a level-one heading

  Also this is not responsive

  Marked as helpful

  0

  ---

  

  Nicolás Herrera•70

  @herreranicolasPosted almost 3 years ago

  @kacperkwinta thanks a lot for your feedback 🙏 how would you say I can apply a more responsive design? I'll search for videos and info on the web about it. I'm not using any framework yet since I want to practice the basics.

  0

  

  Kacper Kwinta•1,405

  @kacperkwintaPosted almost 3 years ago

  @herreranicolas maybe we can try to code one challenge together?

  Marked as helpful

  0

  

  Nicolás Herrera•70

  @herreranicolasPosted almost 3 years ago

  @kacperkwinta that sounds just awesome 👏 I've never coded with anyone so I don't know how can we do it. What about you?

  0

  

  Kacper Kwinta•1,405

  @kacperkwintaPosted almost 3 years ago

  @herreranicolas we can use Live Share in VS Code to code together, and maybe Discord to talk if you want

  0
• 

  Anosha Ahmed•9,300

  @anoshaahmedPosted almost 3 years ago

  hey good job on this challenge! you should have at least one <h1> in your webpage

  here is a list i made of accessibility issues & best practices

  hope this helps :))

  0