QR code component using HTML and CSS

Community feedback

• 

  Casparas•60

  @termissuesPosted about 2 years ago

  Hey, congratulations on your first challenge on Frontend Mentor!

  1. Your HTML file should have one <main> landmark. It's the same as having content inside a <div> tag, but it's necessary to use this in an easier and more practical way in these kinds of challenges.

  2. Your HTML page should contain a level-one heading tag <h1>.

  3. Try using the flex-box and center out your card, it's more practical and more officiant.

  Marked as helpful

  1
• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hello Gabi, congratulations for you solution!

  You did a really good solution really, the container is really good done and flexible!

  To improve it a bit you can use semantic tags to wrap your container, in this case you can use <main> and if you want to clean a bit your css you can select all the elements without using any class, you can just call its selectors direct into the css with main, p, h1, img and manage everything!

  Hope it helps and happy coding!

  Marked as helpful

  1
• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  Hi Gabi,

  Congratulation on completing this challenge. Your solution looks great. I see you have received some incredible feedback. I have some suggestions regarding your solution if you don’t mind:

  • Use the <main> landmark to wrap the card. HTML5 landmark elements are used to improve navigation experience on your site for users of assistive technology.

  • Page should contain <h1>. In this challenge , as it’s supposed to be a part of a whole page, you may use<h1>with sr-only class hidden visually and present for assistive tech users.

  • In my opinion , the alternate text is needed on this image. It should indicate where the *Qr code navigate the user : like Qr code to frontend mentor.

  • Consider using rem for font size .If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices.

  Aside these, Great work again. Hopefully his feedback helps.

  Marked as helpful

  0