Design comparison
Community feedback
- @HassiaiPosted over 1 year ago
instead of giving the image and inline-styling give it a max-width of 100% and a border-radius, This will make the image fit into the main and make it responsive.
in the css give the img a max-width and a border-radius value
img{ max-width:100%; border-radius: 0.65em/rem;}
instead ofwidth="250px" height="250px"
in the img tag of the html.Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful0 - @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
QR iMAGE ALT TEXT 📸:
- The QR Code Component involves scanning the QR code, the image is not a decoration, so it must have an
alt
attribute which should explain the purpose of theimage
.
- The
alt
withQR Code image
is not even explaining for what the QR image need to be used.
- So update the
alt
with meaningful text which explains likeQR code to frontendmentor.io
- Example:
<img src="/images/image-qr-code.png" alt="QR code to frontendmentor.io">
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord