QR Code Component using HTML and CSS

Community feedback

• 

  Rio Cantre•9,690

  @RioCantrePosted almost 3 years ago

  Hello there! Awesome work with this challenge! Looking at your solution you implemented well the code for the design and I would only suggest this for you...

  • Instead of wrapping the section content with another section, use a specific tag like main to wrap the container as a semantic HTML
  • Same goes with attribution wrap it with footer tag

  Hope this helps and Keep going! Cheers!

  Marked as helpful

  1
• 

  Anosha Ahmed•9,300

  @anoshaahmedPosted almost 3 years ago

  hey good job on this challenge! your report above shows a few issues though:

  • wrap everything in your body in <main> OR use semantic tags! if you're using div right after body, then give them a role=""; however, it's a little frowned upon to use role right after body, so try to stick with semantic tags instead. you can read more about landmarks here
  • start headings with <h1>, and move up by one level each time
  • <section> and <article> usually need a heading; if you don't need a heading, use some other element such as <div>

  here is a list i made of accessibility issues & best practices

  hope this helps :))

  0