Design comparison
SolutionDesign
Solution retrospective
Hi there,
This is my project on QR Code built-in HTML and CSS.
It seems to be easy but I found some difficulties when it comes to styling it.
What do you think about it? Maybe it's not really the way I should proceed.
What do you think I missed?
Need your feedback that can help me code better.
Community feedback
- @denieldenPosted about 2 years ago
Hello Kefi, You have done a good work! 😁
Some little tips to improve your code:
- add
main
tag and wrap the card for improve the Accessibility - also you can use
article
tag instead of a simplediv
to the container card for improve the Accessibility - add
width: 100%
toimg
- to make it look as close to the design as possible add
width: 22rem
to.card
class - use flexbox to the body to center the card. Read here -> best flex guide
- after, add
min-height: 100vh and margin: 0
to body because Flexbox aligns child items to the size of the parent container - instead of using
px
use relative units of measurement likerem
-> read here
Keep learning how to code with your amazing solutions to challenges.
Hope this help 😉 and Happy coding!
Marked as helpful0@TroolKongPosted about 2 years ago@denielden Hi Deniel, nice to meet you. I will try all the tips you share with me to improve my code. Thank you very much.
1 - add
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord