Skip to content
Submitted about 2 years ago

QR code component using html and css.

Rafael Okida•10
@okida-rafael
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Melvin Aguilar 🧑🏻‍💻•61,140
    @MelvinAguilarPosted about 2 years ago

    Hi @okida-rafael 👋, good job completing this challenge, and welcome to the Frontend Mentor Community! 🎉

    Here are a few suggestions I've made that you can consider in the future if you're looking to improve the solution further:

    With semantic tags:

    <body>
   <main class="container">
      . . .
   </main>
   <footer class="attribution">
      . . .
   </footer>
<body>
    • The container isn't centered correctly. You can use flexbox to center elements:
    body {
  width: 100%;
  min-height: 100vh;
  display: flex;
  flex-direction: column;
  justify-content: center;
  align-items: center;
}

    Links with more information:

    To improve your solution on mobile devices:

    • Instead of using pixels in font size, use relative units of measure like rem or em. The font size in absolute length units (px) does not allow users with limited vision to change the text size in some browsers. Reference.
    • Use max-width: 300px to .container selector instead of width, this will make the card container a bit responsive on mobile and set the element's maximum width to 300px. Remove this to make the image responsive:
    .image {
    /* width: 290px; */
}

    I hope those tips will help you.

    Good job, and happy coding!

    Marked as helpful
    2
    Rafael Okida•10
    @okida-rafaelPosted about 2 years ago

    @MelvinAguilar thanks for the tips!!!

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord