QR Code Component Using HTML and CSS

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using margin or padding.

  ---

  • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states

  ---

  • To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📚.

  ---

  • For this demonstration we use css Grid to center the component.

  body {
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  • Now remove these styles, after removing you can able to see the changes

  .card {
  margin: auto;
  margin-top: 10%;
  }
  

  ---

  • Now your component has been properly centered

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  Rizki Bagus•50

  @RizkiB12Posted over 1 year ago

  @0xAbdulKhalid Thank you so much, hope god always bless you

  0
• 

  Caius-Scipio•70

  @Caius-ScipioPosted over 1 year ago

  Hey there,

  Great job on completing the solution!

  I think you can improve on your design with semantic tags and relocating an item.

  For example: <div class="card-title"><p>Improve your front-end skills by building projects</p></div>

  could be: <div class="card-title"><h1>Improve your front-end skills by building projects</h1></div>

  Changing the attribution to here, would take it out of the QR Code itself:

  </div>
  <div class="attribution">Challenge ...
  </section>
  </body>
  

  Of course, after these few changes, you'll need to readjust your grid layout and increasing a bit of the padding around the title and description portions. Keep tinkering and you can get closer.

  But overall, well done! You've already got through the toughest part and well on your way!

  Marked as helpful

  1