Travolgi 🍕• 31,420
@denielden
Posted
Hi Ryan, I took some time to look at your solution and you did a great job!
Upload the files directly to the repository and not into the qr-code-component-main
folder otherwise to see it the link is this: https://ryanindrjaya.github.io/qr-code/qr-code-component-main/
Also I have some tips for improving your code:
- add
main
tag and wrap the card for Accessibility - Centering a
div
withabsolute
positioning is now deprecated, it uses modern css likeflexbox or grid
- remove all
margin
fromcard
class - try to use flexbox to the body for center the card. Read here -> best flex guide
- after add
min-heigth: 100vh
to body because Flexbox aligns to the size of the parent container
Overall you did well :)
Hope this help and happy coding!
Marked as helpful
0
Ryan Indrajaya• 30
@ryanindrjaya
Posted
Hi! @denielden thank you so much for your time to give a feedback on my code, I will note all your of your tips. Cheers!
1