Design comparison
Community feedback
- @Aliyu-SaiduPosted almost 2 years ago
Congratulations, Nilasish Roy. I really like your solution. Find below some tips to improve your code!
-
Every Webpage should be contained in a landmark. In this case, you may use <main> and <footer> in place of <div class="project" > and <div class="attribution" > respectively, to improve the accessibility of your website. You can read more on accessibility on (https://web.dev/accessible/?gclid=CjwKCAiA7IGcBhA8EiwAFfUDsfX-xPDXrqqo7B0vZV44epOKlmpslZ4tepkhgjL7p6-gSKHmG7Li8RoC1_MQAvD_BwE).
-
You may also want to check the accessibility report links above too to read more on the subject.
-
You place the project vertically and horizontally in the center of the page, you could use css Flexbox (https://www.w3schools.com/css/css3_flexbox.asp) or Grid (https://www.w3schools.com/css/css_grid.asp).
-
If you have any specific questions, feel free to contact me. Hope this is helpful? Please if you like the feedback, consider hitting the helpful button and also give me an upvote. Thank you!
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord