QR Code component using HTML and CSS

Community feedback

• 

  Abdul•8,540

  @SamadeenPosted over 2 years ago

  Hey!! Cheers 🥂 on completing this challenge.. .

  Here are my suggestions..

  • You should use <main class="card"> instead of <div class="card">.
  • Go down orderly when you are using the headings h1 down to h2 down to h3 and so on.
  • You can wrap your attribution <p class="credit"> section in a footer tag to avoid accessibility issues.

  This should fix most of your accessibility issues

  . Regardless you did amazing... hope you find this useful... Happy coding!!!

  0

  ---

  

  Muhammed Irshath•10

  @MuhammedIrshath49Posted over 2 years ago

  @Samadeen Roger Sir, will improve my code

  0
• 

  Luca•40

  @DeveloperLucaJPosted over 2 years ago

  Hello Muhammed you should not use absolute Units like rem or px. Rather use relative units like vh, vw, vmin or vmax. This will make your page look good on any screen size. Additionally you should remove your inline styles (width on card class) if you have an extra stylesheet. Good luck on your journey

  0

  ---

  

  Muhammed Irshath•10

  @MuhammedIrshath49Posted over 2 years ago

  @DeveloperLucaJ I've already removed due to separation of concerns. Anyways, thanks for the heads up

  0