Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component using HTML and CSS

@Meteo-Flagyl00

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I still need to learn a lot ... of how i set my layout and what i should start with .. that comes with time

Community feedback

Vanza Setia 27,795

@vanzasetia

Posted

Hello, @Meteo-Flagyl00! 👋

Congratulations on completing your first Frontend Mentor challenge! 🎉

There are a lot of things that you can improve.

  • First, I recommend using flexbox to position to the middle of the page. position: fixed makes the card out of the normal flow. As a result, it makes it hard to style.
  • The only thing that the card needs to be responsive is a max-width. You only need to prevent the card from becoming too large on a wide screen. For the height of it, let the content inside it dictate it.
  • If all the values of the padding are the same (padding: 10px 10px 10px 10px;), you can make it shorter by writing it like this: padding: 10px;.
  • I recommend improving the alternative text of the QR code to "QR code for frontendmentor.io". It's going to give the users clear information about the QR code.

Overall, great work. You manage to keep the specificity of the CSS as low as possible. So, keep learning and happy coding! 😄

Marked as helpful

1

@Meteo-Flagyl00

Posted

Hello, @vanzasetia Thank you so much for your time brother, I knew I had a lot of things that I need to work on I just didn't know what are they. I will try to work on the things u pointed out in the next challenges , and once again thank u so much for your time.

0
Vanza Setia 27,795

@vanzasetia

Posted

@Meteo-Flagyl00 No problem! 👍

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord