QR Code Component Using CSS Flexbox

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted almost 2 years ago

  Hello there! 👋

  You should avoid having two separate HTML files with different viewport meta tags for different devices. Your website should be responsive, and you only need one HTML file to make it work. So, you should have the value device-width (for the width) instead of a specific pixel value.

  Remove all <br> elements. You should not use <br> elements to create a whitespace between the card and the attribution. Screen readers may announce them as "break" which creates unnecessary noises.

  Learn more — <br>: The Line Break element - HTML: HyperText Markup Language | MDN #accessibility_concerns

  I hope this helps. Have a great coding day! 😄

  1
• 

  naharki•20

  @naharkiPosted almost 2 years ago

  Its good however there is a certain things that you must apply in upcomming chalenges as, --> Read blog on HTML Semantics like <main> <footer> etc. --> Read a blog on align items, justify content and apply then in code, do not use sole margin and padding this may cause difficulty on responsiveness later. --> <img src="image-qr-code.png" alt=" include alt in img tag"> -->

  0