Arber Lisaj• 360
@arberlisaj
Posted
This comment was deleted
1
SNYLO• 10
@mecha-mann
Posted
@arberLisaj Thanks a lot for the feedback. I'll take a look at semantic elements. And for the variable naming, I'll keep that in mind. 🤓✌️ Thank you
0
Design comparison
Solution retrospective
Do you have any questions about best practices with writing CSS?
Community feedback
Abdul Khaliq 🚀• 72,660
@0xabdulkhaliq
Posted
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
QR iMAGE ALT TEXT 📸:
- The QR Code Component involves scanning the QR code, the image is not a decoration, so it must have an
altattribute which should explain the purpose of theimage.
- The
altwithqr-code.pngis not even explaining for what the QR image need to be used.
- So update the
altwith meaningful text which explains likeQR code to frontendmentor.io
- Example:
<img src="/images/image-qr-code.png" alt="QR code to frontendmentor.io">
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
1
SNYLO• 10
@mecha-mann
Posted
@0xAbdulKhalid hi. Thanks for the feedback. I was so focused on styling that I totally forgot to add the alt text. Thank for pointing it out. I'll update it asap. ✌️😊
0
Abdul Khaliq 🚀• 72,660
@0xabdulkhaliq
Posted
@mecha-mann Glad you found it helpful ! 🤠
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord