@FraCav99
Posted
Hi Fareed, congrats on completing this challenge!
Your solution is great, just one thing is to put a value inside the alt attribute.
Sometimes it's not necessary, if the image you're using is just decorative, like a logo or an icon, but in this case it's good to put one, just a brief one, like alt="qr code link" or something like that.
Also, don't use px units for font-size, but use rem. This because if the user will change the default font size from browser settings, the size of the font will always be the same, and it's not good for accessibility!
I'll share a useful blog post from Josh Comeau which explains the differences and how to build an inuition on which unit to use in any scenario.
It's useful for people with visual impairments which happen to use screen readers. Overall, good job and keep up the good work! :D
Marked as helpful
@hsfarid
Posted
Hello Francesco, thank you very much for your feedback. I find your feedback very informative and useful, and I really appreciate it. I will make sure to put that to use in my future projects.
