Design comparison
SolutionDesign
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
HTML 🏷️:
- Your solution generates accessibility error reports due to
non-semantic
markup
- So fix it by replacing the
<div id="design">
with semantic element<main>
to improve accessibility and organization of your page.
- Use HTML5 semantic elements such as
<header>
,<nav>
,<main>
,<aside>
, and<footer>
to define these sections
I hope you find it helpful ! 😄 Above all, the solution you submitted is great!
Happy coding!
Marked as helpful0 - @John-developer-18Posted over 1 year ago
Dear George Mwawasi, you did a great job by the way.
-
But First I suggest checking the path of your image in your GitHub repo. Your image will not show if there is an error in the path name.
-
Also, try as much as possible to make sure your website looks like the design file given to you. Make references to the style guide if needed.
Marked as helpful0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord