AriyanSep0_0• 330
@ARiYaNSEp0-0
Posted
Hello @hieutrantrong21520859MMCL21. great job on this challenge, your result it'sgood. but :
- your typography on this card have a lot of duplication and there is no need of that. css have something called CSS Inheritance. meaning when you declare some property on top it goes down and apply to descendants (if they don't have that same property on them and by the way mostly typography related properties are inheritable) so for example if you notice a lot of sites mostly apply their typography styles in body or html so research about this concept in css : CSS Inheritance.
- also you shouldn't set height on these cards because contents are dynamic and could be in any length and if you add more text or change width of the card your get and overflowed content so a lot of times you don't need that explicit height
- actual width of this card is 320px. good luck : )
Marked as helpful
0
@hieutrantrong21520859MMCL21
Posted
@ARiYaNSEp0-0 Thank u very much!
0
