Submitted 4 months ago
QR code component using HTML and CSS
@hieutrantrong21520859MMCL21
Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
This is the first web project in my study.
What challenges did you encounter, and how did you overcome them?This is the first time I have tried on a web project, so UI designing and coding are mostly challenging. I had to search for lots of references such as MDN, W3Schools, ...
What specific areas of your project would you like help with?Nothing.
Community feedback
- @ARiYaNSEp0-0Posted 4 months ago
Hello @hieutrantrong21520859MMCL21. great job on this challenge, your result it'sgood. but :
- your typography on this card have a lot of duplication and there is no need of that. css have something called CSS Inheritance. meaning when you declare some property on top it goes down and apply to descendants (if they don't have that same property on them and by the way mostly typography related properties are inheritable) so for example if you notice a lot of sites mostly apply their typography styles in body or html so research about this concept in css : CSS Inheritance.
- also you shouldn't set height on these cards because contents are dynamic and could be in any length and if you add more text or change width of the card your get and overflowed content so a lot of times you don't need that explicit height
- actual width of this card is 320px. good luck : )
Marked as helpful0@hieutrantrong21520859MMCL21Posted 4 months ago@ARiYaNSEp0-0 Thank u very much!
0 - @momand1Posted 4 months ago
Good
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord