QR code Component using HTML & CSS

Community feedback

• 

  P

  Øystein Håberg•10,710

  @Islandstone89Posted 11 months ago

  HTML:

  • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify the "main" section of a page. Replace <section> with <main>.

  • The alt text also needs to say where it leads (frontendmentor.io).

  • Headings should always be in order, so you never start with a <h3>. Change it into a <h1>.

  CSS:

  • Remove margin from the card. To center the card horizontally and vertically, use Flexbox on the body:

  display: flex;
  flex-direction: column;
  justify-content: center;
  align-items: center;
  min-height: 100vh;
  

  • Since all text should be centered, you only need to set text-align: center on the body, and remove it elsewhere. The children will inherit the value. Do the same with font-family.

  • font-size must never be in px. This is bad for accessibility, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • Remove the fixed width on the card. Except for icons, you rarely want to set fixed dimensions(especially heights), as this easily creates issues with responsiveness.

  • Add a max-width of around 20rem on the card, to prevent it from getting too wide on larger screens.

  • On the image, add display: block and change width to max-width: 100% - the max-width prevents it from overflowing its container.

  Marked as helpful

  0

  ---

  

  Aashish•50

  @AashishVivekBhatPosted 11 months ago

  @Islandstone89 thanks a lot for detailed explanation. I'll improve my solution and follow these practices in other challenges as well.

  1