Skip to content
Submitted about 2 years ago

QR Code component using html and css

Noah•70
@noahjrgns
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Lucas 👾•104,340
    @correlucasPosted about 2 years ago

    👾Hello Noah, congratulations for your new solution!

    🎯 Your solution its almost done and I’ve some tips to help you to improve it:

    1.Your solution is great and the code is working, but the html structure can be reduced by removing unnecessary divs, all you need is a single <main> or <div> to keep all the content inside, and nothing more. The ideal structure is the div and only the image, heading and paragraph.

    YOUR CURRENT HTML STRUCTURE:

    <body cz-shortcut-listen="true">
  <div class="container">
    <article class="image">
      <img src="./images/image-qr-code.png" alt="QR">
    </article>
    <article>
      <h1>Improve your front-end skills by building projects</h1>
      <p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
    </article>
  </div>

</body>

    THE STRUCTURE WITH THE HTML REDUCTION:

    <body>
<main>
 <img src="./images/image-qr-code.png" alt="Qr Code Image" >
<h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p> 
</main>
</body>

    2.Improve your alt text writing something more precise to describe the image.

    <img src="./images/image-qr-code.png" alt="QR Code Frontend Mentor">

    ✌️ I hope this helps you and happy coding!

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord