QR code component using html and css

Community feedback

• 

  Danijel Adrinek•420

  @DanijelAdrinekPosted 8 months ago

  Hey Ozim, I liked your project and decided to take a look at it for a bit, and I found some things I think you can improve on.

  1. You should add the text together in one div that should be called text-container, it makes it easier to manipulate the text like that, especially if you're good at using flexbox!

  2. Use CSS variables, they are a powerful tool to help make your code more readable and easy to manipulate

  3. You shouldnt have any @media queries on this project, the sizes of everything are exactly the same on the phone as they are on desktop, since nothing changes, media query isnt necessary

  4. The solution you provide should match the design, it is a bit complicated to understand how to do that for the first time, so if you want, I have written my own blog post on solving this challenge, where I explain how to make pixel-perfect solutions to the challenge.

  https://dev.to/danijeladrinek/frontend-mentor-qr-code-challenge-4g9h

  I hope these tips help you become a better web developer, and help you on your journey towards getting this amazing job!

  if you have any more questions feel free to let me know, have an amazing day, and happy coding :)

  Marked as helpful

  0