Travolgi 🍕• 31,420
@denielden
Posted
Hello Aira, You have done a good work! 😁
Some little tips to improve your code:
- use
main
tag to wrap the card and improve the Accessibility but not as a container of that one element - you can use
article or div
tag instead ofmain
to the container card for improve the Accessibility - add descriptive text in the
alt
attribute of the images - remove all unnecessary code, the less you write the better as well as being clearer: for example the
div
container of texts - use
h1
for the title of card instead of a simpelp
- remove
height and object-fit
properties fromimg
- remove
height
property frombox
class and setwidth: 20rem
- use
min-height: 100vh
to body instead ofheight
, otherwise the content is cut off when the browser height is less than the content - instead of using
px or %
use relative units of measurement likerem
-> read here
Keep learning how to code with your amazing solutions to challenges.
Hope this help 😉 and Happy coding!
Marked as helpful
1