QR code component using Flexbox

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted over 2 years ago

  Hello Allen, congratulations for your solution!

  Answering your question:

  You can improve you code using semantics tags to replace the divs, for example using <main> to replace the div, reduce your code eliminating the unnecessary divs this challenge requires only one div to hold all content (h1, p and Img). To save time you can use variables to work with the colors. Remember to replace the h3 with h1, and to follow a hierarchy sequence for headings using the sequence h1, h2...

  Hope this helps, happy coding!

  1
• 

  Stacey•30

  @staceysavPosted over 2 years ago

  Hi Allen! The page with the QR-code looks excellent! The code is readable and short, it is quite easy to understand what's going on there. I also liked that you used variables. I have no experience in coding, so I can't give you useful feedback. I can share a comment that I got myself: you could wrap the card with the <main> tag to improve navigation for users and engines. This will indicate that the card is the main content of the page. Keep posting your solutions :)

  1
• 

  Illyaas•700

  @Illyaas4ShowPosted over 2 years ago

  Hi, welcome to the community

  This is an amazing solution you've got here. It is almost identical to the design, well done! All you need to do is reduce the width of the card and it will be awesome!

  Hope this helps, Happy coding!

  1