Design comparison
Solution retrospective
Changed my username in the middle of making this so hopefully it doesn't cause any issues. Also, this is my first time submitting something on this site, so I think I might have started it wrong (I made a completely new file/folder instead of using the template provided).
Still working on when to commit/what to write in commit messages. Also I know I can make things overcomplicated so I'm not sure if what I did can be done in a simpler way. And I'm still working on how to make mobile versions. Not totally sure if I did it right here.
But the main issue I had is that when I change the width of the content in styles.css, it will align to the left of the screen. Had the same issue on past projects as well and still haven't figured out a solution to it.
If anybody has any advice (about commit messages, simplification, the width issue, etc) or ways I can improve on any of this I would appreciate it. Thank you :)
Community feedback
- @danielmrz-devPosted 9 months ago
Hello @dgrow9!
Your solution looks excellent!
I have just one suggestion:
- Use only
<main>to wrap the main content instead of<main>and<div>.
š Unless you have a specific reason to do it, there's no need to use two containers. Using only
<main>would even make it easier positioning the elements inside.I hope it helps!
Other than that, great job!
Marked as helpful1@dgrow9Posted 9 months ago@danielmrz-dev
Ohh ok I don't think I've learned about the main element yet, that's where I got confused. Makes sense! Changing it now.
Thanks for the help! :)
1 - Use only
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord