Design comparison
Solution retrospective
I am proud of being able to get close in the first iteration. Next time I will be more prepared because I will study more flexbox.
What challenges did you encounter, and how did you overcome them?I am new in webdesign so flexbox is quite hard to me yet. I had to google somethings
What specific areas of your project would you like help with?I would like to know if there is something or some technic I could have used to make my page more robust and complete.
Community feedback
- @huyphan2210Posted 2 months ago
Hi @rkeppler42,
It looks like this is your first challenge, and you got the QR card 99% accurate to the design—congratulations!
I do have a few suggestions:
- You don’t need to add
width: 100vw
to thebody
because thebody
is already a block-level element, which naturally takes up the full width. Also, instead of settingheight: 100vh
, it’s better to usemin-height: 100vh
to avoid layout issues on smaller viewports (e.g., mobile browsers with dynamic address bars). - Consider using more semantic HTML instead of relying heavily on
div
elements. Semantic elements likearticle
,section
, ormain
provide better context for the content, improving accessibility. - While I don’t have access to the design file, your card looks nearly perfect. Keep in mind that the design may be optimized for specific devices, so it’s often the developer's job to make elements responsive. Rather than hardcoding
width
andheight
values, try usingmin-width
/min-height
ormax-width
/max-height
with specific values, while keepingwidth
/heigh
t relative (e.g., using percentages orvw
/vh
units).
Hardcoded Width/Height (Not Recommended)
.card { width: 320px; height: 499px; }
Responsive Example (Recommended)
.card { max-width: 320px; width: 90%; /* Relative width, adjusts based on the screen size */ min-height: 499px; }
Hope this helps!
Marked as helpful1@rkeppler42Posted 2 months ago@huyphan2210 thanks for your feedback! I really have to study responsiveness! I'm gonna take a deep dive!
0 - You don’t need to add
- @Hana094Posted 2 months ago
it looks good, the only thing I wouls consider is looking at how you are making your comits, because your repo has a lot of wierd files that I think may not be of use, but I can deny that You got the desire result
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord