QR code component using flexbox

Community feedback

• 

  Majdi Neji•140

  @majdi-nejiPosted 3 months ago

  hi chiscookeke11 i think your solution is really great however there are a couple of things that could use some improvements i will list them down below and point out how you can fix them

  • the proportions of the card are a little off i know it can be tricky replicating a design dimensions accuratly that's why i recommend you look into the design in the figma file and see the dimensions like widths,heights,paddings border radius etc and you can even see fonts used with their sizes and weights which will make your solution very close to the design *the second thing i noticed was the fonts and you have mentioned that you need to work more on them well here is how you can implement them on your code first look at the fonts being used on the design on our case it is a font called Outfit "you used poppins" it is a google font so that makes it easier to add it to our website just copy the embeded link and add it to the head tag on your html file like this

  <link rel="preconnect" href="https://fonts.googleapis.com"> <link rel="preconnect" href="https://fonts.gstatic.com" crossorigin> <link href="https://fonts.googleapis.com/css2?family=Outfit:wght@100..900&display=swap" rel="stylesheet"> and specify it on the css properties font-family: "Outfit", serif; also i noticed you chose a different background color maybe it was intentional however generally we want to stay close to our design reference other then that great work and good luck on your journey :D

  Marked as helpful

  0