QR Code Component using Flexbox

Community feedback

• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  Hello rushinstuffin, congratulations for your solution!

  Great solution and great code, what I liked most was the minimal struefor the html, is really rare to see someone that didn't a unnecessary div and you didn't, that's great. If you want to reduce even more the code you delete the class and select all elements in css with the direct seletor for each one since there's only content of each kind.

  You've used h3 here, but since the title bold is the main title for this page you should go with h1 otherwise you'll have the solution report panel giving you an accessibility error, remember to increase the headings following the sequence h1 h2 h3...

  Anyway, amazing solution, it's already done. Keep it up

  Marked as helpful

  2

  ---

  

  rushinstuffin•380

  @kyle-barry-appsPosted about 2 years ago

  @correlucas I appreciate that!

  1
• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  Hello rushinstuffin,

  Congratulation on completing this frontend mentor challenge. Excellent work! I have some suggestions regarding your solution:

  • In my opinion, the image is an important content. The alternate text is needed on this image. The alternate text should indicate where the Qr code navigate the user : like QR code to frontend mentor not describes the image.
  • Page should contain <h1>. To tackle the accessibility issue In this challenge , you may use <h1> instead of <h3 >

  Great job in this one. Hopefully this feedback helps.

  Marked as helpful

  1

  ---

  

  rushinstuffin•380

  @kyle-barry-appsPosted about 2 years ago

  @PhoenixDev22 Thanks so much for the feedback!

  0

  

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  @kyle-barry-apps Glad to help. Happy coding!

  0
• 

  Adriano•38,120

  @AdrianoEscarabotePosted about 2 years ago

  Hi @kyle-barry-apps, how are you?

  I really liked the result of this project, but I have some tips that I think you will like:

  1- Page should contain a level-one heading click here

  The rest is really good! You did a great job on the responsiveness of the project

  Hope it helps... 👍

  Marked as helpful

  0

  ---

  

  rushinstuffin•380

  @kyle-barry-appsPosted about 2 years ago

  @AdrianoEscarabote Got it thanks! I didn't realize this was important for accessibility

  1

  

  Adriano•38,120

  @AdrianoEscarabotePosted about 2 years ago

  @kyle-barry-apps no problem, keep coding

  0