Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

qr code component using flexbox

chrisdh80 70

@chrisdh80

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Im fairly new to HTML and CSS and enjoyed learning flexbox. Any comments or feedback regrding code is much appreciated.

Community feedback

Gabriel 170

@ctrl-brokencode

Posted

Hello! Congrats on uploading this challenge. I hope you don't discourage now and I hope you continue coding and learning from your mistakes. You will go far! Here are some suggestions I've made for you. Make sure to pay attention!

  • On HTML, make the alt text of the image clearer. Say where the QR Code is taking you;
  • Delete the <br> tags in <h1> and <p>. The text will adjust according to the size of the component;

On CSS:

  • Replace the .container selector with the tag body, as it will be the body of the project. It's optional, you can continue with the div.container if you want. (If you actually replace it, take the div.card out of the div.container in HTML file);
  • On display: flex, change flex for grid to center the component later;
  • Remove the width of the body, as it can cause side scrolling on smaller devices. The component should already be centered;
  • Replace justify-content: center; and align-items: center; to place-items: center. It will only take up one line and will have the same effect

It should look like this:

body {
    display: grid;
    height: 100vh;
    background-color: hsl(212, 45%, 89%);
    place-items: center;
}

As for the card:

  • We can delete the following items:
    • display: flex;
    • flex-direction: column;
    • align-items: center;
  • Remove height. Remember that the height in the component will automatically be determined by the its content;
.card {
    flex-direction: column;
    width: 300px;
    background-color: white;
    padding: 1rem;
    border-radius: 1rem;
    text-align: center;
}

And you're pretty much done! Overall, your code is simple and easy to read. I wish you the best of luck!

Marked as helpful

0

chrisdh80 70

@chrisdh80

Posted

@Gabriel-H502

Thank you very much for your detailed feedback

1

@M1ch3ll0101

Posted

Realmente me parece bastante fiel al diseño, algún tamaño un poco diferente, pero sigue siendo proporcional. Felicitaciones!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord